-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix npm's deployment path #273
Conversation
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
93b57f7
to
05c472a
Compare
Hi @connyay, following the above fix do you think that the artifact name should also include the scope? |
@sverdlov93 I am not sure. I don't think so. This test case matches my expectations: build-info-go/build/utils/npm_test.go Line 102 in c694d21
From what I can tell this change will fix jfrog/jfrog-cli#2280 Is there a separate issue about the artifact name not having scope? |
Following your change, we have failing tests on JFrog CLI, so I am trying to understand how to handle that. |
Fixes jfrog/jfrog-cli#2280