Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix npm's deployment path #273

Merged
merged 3 commits into from
Sep 21, 2024
Merged

Fix npm's deployment path #273

merged 3 commits into from
Sep 21, 2024

Conversation

connyay
Copy link
Contributor

@connyay connyay commented Sep 5, 2024

Fixes jfrog/jfrog-cli#2280

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Copy link

github-actions bot commented Sep 5, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@connyay
Copy link
Contributor Author

connyay commented Sep 5, 2024

I have read the CLA Document and I hereby sign the CLA

@eyalbe4 eyalbe4 added the bug Something isn't working label Sep 21, 2024
@eyalbe4 eyalbe4 changed the title fix: Add scope a second time to getdeploypath Fix npm's deployment path Sep 21, 2024
@eyalbe4 eyalbe4 merged commit c694d21 into jfrog:dev Sep 21, 2024
15 of 16 checks passed
@sverdlov93
Copy link
Contributor

sverdlov93 commented Sep 24, 2024

Hi @connyay, following the above fix do you think that the artifact name should also include the scope?
image
because currently its uploaded without it .
jfrog-cli-tests-=1.0.0.tgz > @scope/jfrog-cli-tests-=1.0.0.tgz

@sverdlov93
Copy link
Contributor

Hi @connyay, following the above fix do you think that the artifact name should also include the scope? image because currently its uploaded without it . jfrog-cli-tests-=1.0.0.tgz > @scope/jfrog-cli-tests-=1.0.0.tgz

@connyay

@connyay connyay deleted the cjh-jfrog-cli-2280 branch September 26, 2024 13:46
@connyay
Copy link
Contributor Author

connyay commented Sep 26, 2024

@sverdlov93 I am not sure. I don't think so.

This test case matches my expectations:

{`@jfrog/build-info-go-tests/-/@jfrog/build-info-go-tests-1.0.0.tgz`, &PackageInfo{Name: "build-info-go-tests", Version: "1.0.0", Scope: "@jfrog"}},

From what I can tell this change will fix jfrog/jfrog-cli#2280

Is there a separate issue about the artifact name not having scope?

@sverdlov93
Copy link
Contributor

Following your change, we have failing tests on JFrog CLI, so I am trying to understand how to handle that.
For example:
{
"name": "@my-scope/my-package",
"version": "1.0.0",
"description": "A sample scoped package",
}
The artifact name here should be @my-scope/my-package or my-package ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Published scoped npm packages gets wrong path using JF CLI
3 participants